[Coding Rule]: assure visibility of unsafe keyword in unsafe code#358
Open
rcseacord wants to merge 9 commits intorustfoundation:mainfrom
Open
[Coding Rule]: assure visibility of unsafe keyword in unsafe code#358rcseacord wants to merge 9 commits intorustfoundation:mainfrom
rcseacord wants to merge 9 commits intorustfoundation:mainfrom
Conversation
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rcseacord
changed the title
Updated guideline to ensure visibility of unsafe tokens in unsafe code, reflecting changes in Rust Edition 2024. Added rationale and examples to clarify requirements.
Update guideline to ensure visibility of 'unsafe' keyword in unsafe code, reflecting changes in Rust Edition 2024.
Clarify issues with using #[export_name] and #[link_section] attributes without unsafe wrappers in Rust 2024.
Removed visibility section and updated examples for compliance with Rust Edition 2024. Clarified unsafe usage in function declarations and attributes.
Removed exceptions section and added safety notes for unsafe attributes.
PLeVasseur
force-pushed
the
guideline/unsafetoken
branch
from
d8d653b to
e1044d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created PR for #252 by @workingjubilee