Add IME event support for Wayland #2154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
added
the
DS - wayland
kchibisov
force-pushed
the
new-wayland-composition-event
branch
2 times, most recently
from
b4b7173 to
e84ba2f
Compare
Member
Author
|
If someone is interested in testing it in client the support is implemented in alacritty/alacritty#5790 |
rano-oss
approved these changes
Jan 18, 2022
rano-oss
suggested changes
Jan 18, 2022
rano-oss
left a comment
rano-oss
left a comment
There was a problem hiding this comment.
Could you bump wayland-rs (protocols/client) to 29.4? There is a use after free bug that has been fixed there. It might make the text gibberish.
Except for that it looks great!
Member
Author
Usually you don't need that, since downstream can do that. Though we could force the usage of 0.29.4 in winit I guess.(alacritty is already using it for example). |
kchibisov
force-pushed
the
new-wayland-composition-event
branch
from
e84ba2f to
b959e2a
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.