Skip to content

Add ModifiersChanged event for macOS #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2019
Merged

Add ModifiersChanged event for macOS #1268

merged 3 commits into from
Dec 12, 2019

Conversation

@chrisduerr
Copy link
Contributor

@chrisduerr chrisduerr commented Nov 9, 2019

This implements the macOS portion of #1124.

@chrisduerr chrisduerr force-pushed the macos-mod-change-event branch from 848056f to 54d560d Compare November 9, 2019 16:58
@chrisduerr chrisduerr mentioned this pull request Nov 9, 2019
Closed
10 tasks
@goddessfreya goddessfreya added DS - appkit Affects the AppKit/macOS backend C - waiting on maintainer A maintainer must review this code labels Nov 11, 2019
@murarth
Copy link
Contributor

murarth commented Nov 14, 2019

With #1262 merged, this needs to be updated to generate ModifiersChanged as a DeviceEvent.

@chrisduerr chrisduerr force-pushed the macos-mod-change-event branch from 54d560d to 2cfe108 Compare November 14, 2019 22:25
@chrisduerr
Copy link
Contributor Author

chrisduerr commented Nov 15, 2019

Should be good to go now. Thanks for the note @murarth.

vbogaevsky
vbogaevsky suggested changes Dec 8, 2019
View reviewed changes
Copy link
Contributor

@vbogaevsky vbogaevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisduerr could you update CHANGELOG.md with this changes, please?
Otherwise it's ready for merge.

@chrisduerr
Copy link
Contributor Author

chrisduerr commented Dec 8, 2019 •
edited
Loading

@chrisduerr could you update CHANGELOG.md with this changes, please?
Otherwise it's ready for merge.

I intentionally did not add this to the changelog, because the X11 commit held out on a changelog addition until it is supported on all platforms.

That's why it is also still behind a #[doc(hidden)] attribute.

@chrisduerr
Copy link
Contributor Author

chrisduerr commented Dec 12, 2019

@vbogaevsky Any update on how to proceed? Should I add a changelog or not?

Or wait until the Windows PR is sent to finish things off?

@vbogaevsky
Copy link
Contributor

vbogaevsky commented Dec 12, 2019

@chrisduerr I'm merging this PR, and lets add changes to CHANGELOG.md in Windows PR.

@vbogaevsky vbogaevsky merged commit c1b93fc into rust-windowing:master Dec 12, 2019
@chrisduerr chrisduerr deleted the macos-mod-change-event branch December 12, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vbogaevsky vbogaevsky vbogaevsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C - waiting on maintainer A maintainer must review this code DS - appkit Affects the AppKit/macOS backend

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisduerr @murarth @vbogaevsky @goddessfreya