Skip to content

Conversation

@dhardy
Copy link
Member

@dhardy dhardy commented Oct 3, 2018

Fixes #618

@dhardy dhardy merged commit fbd9ec3 into rust-random:master Oct 3, 2018
@burdges
Copy link
Contributor

burdges commented Oct 3, 2018

ReadRng does not itself satisfy either TrustedLen or FusedIterator, right? It's okay because DistIter panics instead of propagating those errors though I guess.

@dhardy
Copy link
Member Author

dhardy commented Oct 3, 2018

Panic is basically a type-safe way of avoiding the usual guarantees on return values — be it an "unexpected" failure of a supposedly infinite iterator, or a failure to allocate a new Box etc. So I see no issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants