-
-
Notifications
You must be signed in to change notification settings - Fork 485
Changes to rand_core readme #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b7c7871 to
2e2587c
Compare
|
Why not just rebase this on top of my PR? |
|
I will 😄. |
a7997ce to
4158080
Compare
4158080 to
4788a0e
Compare
|
Do we also want to document the minimum Rust version for |
|
You can add the minimum Rust version if you like (along with extra CI test), but I don't see much point; once for the whole Rand project should be enough since most people will use |
dhardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| [](https://travis-ci.org/rust-lang-nursery/rand) | ||
| [](https://ci.appveyor.com/project/alexcrichton/rand) | ||
| [](https://crates.io/crates/rand) | ||
| [](https://docs.rs/rand) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need two doc links? Well, okay..
|
As there is only one version of |
I looked up the pre-release of rand_core on crates.io, and found some things that could improve in the readme.
Added badges, link to changelog, removed 'primarily' from licence text, added license links, and fixed broken link to Rand.
Example rendering: https://github.com/pitdicker/rand/blob/rand_core_readme/rand_core/README.md