-
-
Notifications
You must be signed in to change notification settings - Fork 485
Various changes to ChaChaRng
#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
17b9571
Add tests for ChaChaRng set_counter
pitdicker f6ddbe9
Make the number of rounds in ChaCha variable
pitdicker c22c5d5
Extend ChaChaRng documentation
pitdicker b053638
Improve performance of ChaChaRng::update
pitdicker 8abe13a
Fold ChaCha init into from_seed
pitdicker feb5b10
Address review comments
pitdicker 4a44964
Add benchmarks for ChaChaRng with 8 and 12 rounds
pitdicker c17f7f1
Fix for Rust 1.15
pitdicker fb5b3bb
Add back test_chacha_set_counter
pitdicker 12e911c
Fix spelling mistakes
pitdicker c320c7d
Replace `SeedableRng::from_seed` with `ChaChaRng::from_seed`
pitdicker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's time you stopped confusing 'to' and 'too'!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I will try too not make to many mistakes with them anymore. Starting tomorrow 😄.