Remove unnecessary underscore from impl<T, const N: usize> Distribution<[T; N]> for StandardUniform#1585
Merged
benjamin-lieser merged 1 commit intoFeb 13, 2025
Conversation
Member
|
This has nothing to do with the removed underscore, because the current master also fails now. Do you want to investigate this? If not I can do it and would put commits on this branch. |
Member
|
So |
Contributor
Author
Thanks. I agree to fix the broken code and commits it to this branch. |
Member
|
I have opened a different pull request for this issue #1586 , if this gets merged, you can rebase and this should then also work. |
98756f5 to
97d0443
Compare
benjamin-lieser
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Remove the leading underscore from the
_rngparameter of thesamplemethod.Motivation
Because this parameter appears to be used. I think suppressing the
unused_variableslint is unnecessary.