Split protable vector types tests into multiple crates #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo.toml
Outdated
| members = [ | ||
| "crates/stdsimd-verify", | ||
| "crates/stdsimd", | ||
| "crates/coresimd_v16_tests", |
Member
There was a problem hiding this comment.
Could these perhaps be organized under crates/coresimd/tests/*.rs?
That'd mean that cargo test -p coresimd should hopefully pick up everything
Member
|
Looks great to me! My only real comment is about moving these to unit test crates rather than actual crates (which I think won't be too hard?), but otherwise looks good! |
Contributor
Author
|
@alexcrichton done! I've never thought about the files in the tests/ directory as "crates" ! But that's exactly what they are, thanks! |
Contributor
Author
|
I've merged the rustc reduction intrinsics here to remove the codegen modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are still defined inline with the code but now there are a bunch of macros that control whether they are compiled or not.
The
crates/coresimd_v{...}_teststhen define these macros to include the tests.To avoid recompiling
coresimd, these crates add it as a dependency, and they includeppsvmodule using#[path = "..."].