-
Notifications
You must be signed in to change notification settings - Fork 1k
Trailing comma left when collapsing vertical argument list to single line #2918
Copy link
Copy link
Closed
Labels
A-macrosArea: macros (procedural macros, macro_rules! macros, etc.)Area: macros (procedural macros, macro_rules! macros, etc.)I-poor-formattingIssue: poor formattingIssue: poor formattingwont-fix
Description
Using rustfmt 0.99.2-nightly (5c9a2b6 2018-08-07) on this:
impl Foo {
pub fn get_key(&self) -> Result<String, MailParseError> {
Ok(
try!(encoding::all::ISO_8859_1.decode(
self.key,
encoding::DecoderTrap::Strict,
)).trim()
.to_string(),
)
}
}collapses the decode call onto a single line which is fine, but it keeps the trailing comma. My understanding is that the default value for trailing_comma is Vertical which should delete the comma.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-macrosArea: macros (procedural macros, macro_rules! macros, etc.)Area: macros (procedural macros, macro_rules! macros, etc.)I-poor-formattingIssue: poor formattingIssue: poor formattingwont-fix
Type
Fields
Give feedbackNo fields configured for issues without a type.