Skip to content

Switch self profile to use HW counters instead of walltime #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kobzol merged 3 commits into from
Aug 12, 2023
Merged

Switch self profile to use HW counters instead of walltime #1647

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b72313
Switch self profile to use HW counters instead of walltime
Kobzol Jul 8, 2023
7162f86
Document the switch to HW counters
Kobzol Jul 18, 2023
47e20b8
Change formatting of self-profile metrics
Kobzol Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion collector/src/bin/rustc-fake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@ fn main() {
if wrapper == "PerfStatSelfProfile" {
cmd.arg(&format!(
"-Zself-profile={}",
prof_out_dir.to_str().unwrap()
prof_out_dir.to_str().unwrap(),
));
cmd.arg("-Zself-profile-counter=instructions:u");
let _ = fs::remove_dir_all(&prof_out_dir);
let _ = fs::create_dir_all(&prof_out_dir);
}
Expand Down
13 changes: 6 additions & 7 deletions site/frontend/templates/pages/detailed-query.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,20 +79,19 @@ <h4>Artifact Size</h4>
<tbody id="artifact-body">
</tbody>
</table>
<p>'Time (%)' is the percentage of the cpu-clock time spent on this query (we do not use
wall-time as we want to account for parallelism).</p>
<p>'Instructions (%)' is the percentage of instructions executed on this query.</p>
<p>Executions do not include cached executions.</p>
<table>
<thead>
<tr id="table-header">
<th data-sort-idx="1" data-default-sort-dir="1">Query/Function</th>
<th data-sort-idx="10" data-default-sort-dir="-1">Time (%)</th>
<th data-sort-idx="2" data-default-sort-dir="-1">Time (s)</th>
<th data-sort-idx="11" data-default-sort-dir="-1" class="delta">Time delta</th>
<th data-sort-idx="10" data-default-sort-dir="-1">Instructions (%)</th>
<th data-sort-idx="2" data-default-sort-dir="-1">Instructions</th>
<th data-sort-idx="11" data-default-sort-dir="-1" class="delta">Instructions delta</th>
<th data-sort-idx="5" data-default-sort-dir="-1">Executions</th>
<th data-sort-idx="12" data-default-sort-dir="-1" class="delta">Executions delta</th>
<th class="incr" data-sort-idx="7" data-default-sort-dir="-1" title="Incremental loading time">
Incremental loading (s)</th>
<th class="incr" data-sort-idx="7" data-default-sort-dir="-1" title="Incremental loading instructions">
Incremental loading instructions</th>
<th class="incr delta" data-sort-idx="13" data-default-sort-dir="-1">Incremental loading delta</th>
</tr>
</thead>
Expand Down
2 changes: 1 addition & 1 deletion site/src/request_handlers/self_profile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ pub async fn handle_self_profile(
.benchmark(selector::Selector::One(bench_name.to_string()))
.profile(selector::Selector::One(profile.parse().unwrap()))
.scenario(selector::Selector::One(scenario))
.metric(selector::Selector::One(Metric::CpuClock));
.metric(selector::Selector::One(Metric::InstructionsUser));

// Helper for finding an `ArtifactId` based on a commit sha
let find_aid = |commit: &str| {
Expand Down