Skip to content

A better message for unrolled rollup #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mark-Simulacrum merged 1 commit into from
Aug 1, 2022
Merged

A better message for unrolled rollup #1376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions site/src/request_handlers/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,18 @@ async fn handle_rollup_merge(
use std::fmt::Write;
let (pr, commit) = n?;
let mut string = string?;
write!(&mut string, "#{pr}: {commit}\n").unwrap();
write!(
&mut string,
"|#{pr}|[{commit}](https://github.com/rust-lang-ci/rust/commit/{commit})|\n"
)
.unwrap();
Ok(string)
})?;
let msg =
format!("Try perf builds for each individual rolled up PR have been enqueued:\n{mapping}");
format!("📌 Perf builds for each rolled up PR:\n\n\
|PR# | Perf Build Sha|\n|----|-----|\n\
{mapping}\nIn the case of a perf regression, \
run the following command for each PR you suspect might be the cause: `@rust-timer build $SHA`");
main_repo_client.post_comment(rollup_pr_number, msg).await;
Ok(())
}
Expand Down