Skip to content

Option::and is not as polymorphic as it can be #9773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
micahrj wants to merge 2 commits into from
Closed

Option::and is not as polymorphic as it can be #9773

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6017b3c
Option::and is not as polymorphic as it can be
micahrj Oct 8, 2013
c5ee0d8
make Option::and fully polymorphic
micahrj Oct 9, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libstd/option.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ impl<T> Option<T> {

/// Returns `None` if the option is `None`, otherwise returns `optb`.
#[inline]
pub fn and(self, optb: Option<T>) -> Option<T> {
pub fn and(self, optb: Option<U>) -> Option<U> {
Copy link
Member

@alexcrichton alexcrichton Oct 8, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will fail to compile because of the undeclared U type parameter.

Copy link
Contributor Author

@micahrj micahrj Oct 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right. It needs to be and<U>.

match self {
Some(_) => optb,
None => None,
Expand Down