Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Mar 20, 2022

The docs for the default filename for --emit=metadata was wrong, it was missing the lib prefix. The current implementation for that default is here. Perhaps somewhat confusing, but lib is used for all crate types.

cc #68839 (comment)

@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 20, 2022
@bjorn3
Copy link
Member

bjorn3 commented Mar 20, 2022

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Mar 20, 2022

📌 Commit 9da3c35 has been approved by bjorn3

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2022
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#95114 (Skip a test if symlink creation is not possible)
 - rust-lang#95131 (Fix docs for default rmeta filename.)
 - rust-lang#95135 (Fix a not emitted unmatched angle bracket error)
 - rust-lang#95145 (Fix typo interator->iterator)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7557c08 into rust-lang:master Mar 21, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants