Skip to content

Add a better error message for #39364 #88612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 3 commits into from
Sep 24, 2021
Merged

Add a better error message for #39364 #88612

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaa6de7
Add a better error message for #39364
lovasoa Sep 3, 2021
f63096e
rust fmt
lovasoa Sep 5, 2021
598e5b2
Update library/std/src/sync/mpsc/shared.rs
m-ou-se Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion library/std/src/sync/mpsc/shared.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,11 @@ impl<T> Packet<T> {
// Returns true if blocking should proceed.
fn decrement(&self, token: SignalToken) -> StartResult {
unsafe {
assert_eq!(self.to_wake.load(Ordering::SeqCst), 0);
assert_eq!(
self.to_wake.load(Ordering::SeqCst),
0,
"This is a known bug in rust. See https://github.com/rust-lang/rust/issues/39364"
);
let ptr = token.cast_to_usize();
self.to_wake.store(ptr, Ordering::SeqCst);

Expand Down