Add #[track_caller] for some function in core::mem.#86664
Merged
Conversation
m-ou-se
added
T-libs
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnTitor
approved these changes
Jul 13, 2021
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Makes sense to me. Feel free to r=me if this doesn't need a full t-libs-api member's review.
Member
Author
|
Thanks for the review! @bors r=JohnTitor |
Collaborator
|
📌 Commit b490dbdeb427d4c54984085cf18c7dfd87f1dd6f has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit b490dbdeb427d4c54984085cf18c7dfd87f1dd6f with merge a3d54864adfb5b8d713f9546460c80f2eccaa0a3... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
JohnTitor
added
S-waiting-on-author
These functions can panic for some types. This makes the panic point to the code that calls e.g. mem::uninitialized(), instead of inside the definition of mem::uninitialized.
m-ou-se
force-pushed
the
uninit-track-caller
branch
from
b490dbd to
3f6dc9a
Compare
Member
Author
|
Rebased and blessed the test output. @bors r=JohnTitor |
Collaborator
|
📌 Commit 3f6dc9a has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 3f6dc9a with merge 34e37bdbb491451aa684976d765796616b217443... |
Collaborator
|
💔 Test failed - checks-actions |
Collaborator
bors
added
S-waiting-on-review
Member
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions can panic for some types. This makes the panic point to the code that calls e.g. mem::uninitialized(), instead of inside the definition of mem::uninitialized.