Skip to content

Line numbers aligned with content #86542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Jun 23, 2021
Merged

Line numbers aligned with content #86542

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3af9c91
Update browser-ui-test version
GuillaumeGomez Jun 22, 2021
5c9e10e
Add check to ensure that the line numbers are aligned with the source…
GuillaumeGomez Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/test/rustdoc-gui/source-code-page.goml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ assert-attribute: (".line-numbers > span:nth-child(4)", {"class": "line-highligh
assert-attribute: (".line-numbers > span:nth-child(5)", {"class": "line-highlighted"})
assert-attribute: (".line-numbers > span:nth-child(6)", {"class": "line-highlighted"})
assert-attribute-false: (".line-numbers > span:nth-child(7)", {"class": "line-highlighted"})
// This is to ensure that the content is correctly align with the line numbers.
compare-elements-position: ("//*[@id='1']", ".rust > span", ("y"))
Comment on lines +14 to +15
Copy link
Member

@jyn514 jyn514 Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't hurt, but I also don't think it helps very much? Usually the isuses come from less common browsers because the line numbers use a metric ton of CSS to allow being out-of-line with the code itself.

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all. The issue appeared at least three times on all browsers. There were the line numbers and then completely below the source code. It was caused by changes on the CSS as you may have guessed. ;)