Deny warnings in stage1+ libsyntax/librustc/librustdoc/librusti/librust #8441
Conversation
|
nice |
|
Oh so nice! Thanks for this. |
|
Could you throw this on compiletest as well? |
|
@alexcrichton: thanks for the idea! I updated the PR to HEAD (which required me to fix a warning) and enabled warnings on the tests. |
|
@alexcrichton: you're right, I'm hitting a lot of failures in the tests. Is it possible to r- this until I fix all the tests? |
|
Sure thing. I'm personally in favor of having |
|
Also, once you've fixed all the tests, feel free to r=me p=100 on this pull |
|
This PR isn't ready for merging yet, I just pushed up this code to prevent bors from building it. |
|
Is this good for another go-round? It doesn't appear to have any merge conflicts... |
|
@alexcrichton: At this point I'm just racing other PRs. If I don't land soon, I'll split out my changes to the tests from my modifications to the makefiles. |
|
I'm not sure about this. I worry that this is going to increase our bounce rate significantly for little gain in code quality. |
This patch makes sure that code is warning-free for all of the rust libraries.
Don't lint `needless_borrow` in method receiver positions fixes rust-lang#8408 fixes rust-lang#8407 fixes rust-lang#8391 fixes rust-lang#8367 fixes rust-lang#8380 This is a temporary fix for `needless_borrow`. The proper fix is included in rust-lang#8355. This should probably be merged into rustc before beta branches on Friday. This issue has been reported six or seven times in the past couple of weeks. changelog: Fix various issues with `needless_borrow` n´. Note to changelog writer: those issues might have been introduced in this release cycle, so this might not matter in the changelog.
6 participants
This patch makes sure that code is warning-free for all of the rust libraries.