Ignore nonstandard lldb version strings in compiletest #84132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Manishearth
force-pushed
the
lldb-nonstandard
branch
from
b71c748 to
afaefea
Compare
Member
|
Ok, I did some investigation and it looks like this may end up running more tests than would work in practice, but we don't really support a "max" version for any tests right now so it doesn't run into a problem of not running a test I believe. So should be OK. Thanks! @bors r+ rollup |
Collaborator
|
📌 Commit afaefea has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2021
Rollup of 5 pull requests Successful merges: - rust-lang#84132 (Ignore nonstandard lldb version strings in compiletest) - rust-lang#84521 (Reuse modules on `hermit`) - rust-lang#84563 (Update backtrace to 0.3.57) - rust-lang#84610 (Update Clippy) - rust-lang#84613 (move representability checks to rustc_ty_utils) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84131
Unsure if I should do the same for the Apple LLDB branch above.