Update error to reflect that integer literals can have float suffixes #79329
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
A-diagnostics
Contributor
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
camelid
force-pushed
the
int-lit-suffix-error
branch
from
5d55937 to
b11d0f2
Compare
davidtwco
approved these changes
Nov 25, 2020
Member
|
@bors r+ |
Collaborator
|
📌 Commit b11d0f2 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit b11d0f2 with merge b02208a1d22fdfc560acda765e50c9ee5b90cac5... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
|
@bors retry |
bors
added
S-waiting-on-bors
Member
Author
|
Why have there been so many spurious bors failures? |
Contributor
bors
added
S-waiting-on-author
Member
Author
|
Looks like I need to update clippy tests :/ |
For example, `1` is parsed as an integer literal, but it can be turned into a float with the suffix `f32`. Now the error calls them "numeric literals" and notes that you can add a float suffix since they can be either integers or floats.
camelid
force-pushed
the
int-lit-suffix-error
branch
from
b11d0f2 to
a3cde63
Compare
camelid
added
S-waiting-on-review
Member
Author
|
Okay, should be ready for another |
Member
|
@bors r+ |
Collaborator
|
📌 Commit a3cde63 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 6, 2020
…twco Update error to reflect that integer literals can have float suffixes For example, `1` is parsed as an integer literal, but it can be turned into a float with the suffix `f32`. Now the error calls them "numeric literals" and notes that you can add a float suffix since they can be either integers or floats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
1is parsed as an integer literal, but it can be turnedinto a float with the suffix
f32. Now the error calls them "numericliterals" and notes that you can add a float suffix since they can be
either integers or floats.