Stop BTreeMap casts from reborrowing #74777
Merged
+16
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts. |
ssomers
force-pushed
the
btree_cleanup_7
branch
from
256c0c7 to
27ab6dd
Compare
ssomers
changed the title
ssomers
force-pushed
the
btree_cleanup_7
branch
from
27ab6dd to
9b7de6c
Compare
Contributor
Author
|
Continuing from #75058. |
ssomers
force-pushed
the
btree_cleanup_7
branch
from
9b7de6c to
d88c611
Compare
ssomers
force-pushed
the
btree_cleanup_7
branch
from
d88c611 to
0522040
Compare
Member
|
@bors r+ |
Collaborator
|
📌 Commit 0522040 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Down in btree/node.rs, the interface and use of
cast_uncheckedlook a bit shady. It's really just there for invertingforget_typewhich does not borrow. By borrowing we can't write the samecast_uncheckedin the same way at the Handle level.No change in undefined behaviour or performance.