Skip to content

Conversation

@june0cho
Copy link
Contributor

Fix #5984. Also, I found a problem on type inference and left a comment.

@brson
Copy link
Contributor

brson commented May 28, 2013

@june0cho Thanks! Can you file an issue about the method inference problem?

@nikomatsakis
Copy link
Contributor

I don't believe the failure to find a method is a bug, but rather the impl definitions in the PR are not quite right. In particular, the mut_slice method is defined as:

 +    fn mut_slice(&mut self, start: uint, end: uint) -> &'self mut [T] {...}

but the receiver type is &mut [T]. Really the mut_slice method should therefore just take self, I should think. (Once dynamically sized types lands, the current self type would be the correct one, because the impl type would be [T] not &mut [T]).

bors added a commit that referenced this pull request May 29, 2013
Fix #5984. Also, I found a problem on type inference and left a comment.
@bors bors closed this May 29, 2013
@june0cho
Copy link
Contributor Author

@nikomatsakis you are right. I corrected as you commented and the error does not occur anymore.
I'll update it !

@june0cho june0cho mentioned this pull request May 29, 2013
bors added a commit that referenced this pull request May 29, 2013
Fix #5984.
Resolve the problem which exists in #6780.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 25, 2021
lintcheck: fully rerun lintcheck if clippy was rebuilt since last log update

Automatically clean lintchecks shared target dir (will force clippy to recheck sources) if
the clippy binaries are older than the lintcheck logs.

Also updated lintcheck logs in the pr.

changelog: lintcheck: fully rerun lintcheck if clippy was rebuilt since last log update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants