Skip to content

Documented BinaryHeap performance. #59698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DevQps wants to merge 5 commits into from
Closed

Documented BinaryHeap performance. #59698

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2ff5ed
Documented BinaryHeap performance.
Apr 4, 2019
2920719
Break documentation at the right place.
Apr 5, 2019
dd35395
Rephrased the performance details of BinaryHeap.
Apr 9, 2019
4b82287
Rephrased the documentation of BinaryHeap.
Apr 20, 2019
20a5586
Update src/liballoc/collections/binary_heap.rs
mzji May 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/liballoc/collections/binary_heap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ use super::SpecExtend;
/// trait, changes while it is in the heap. This is normally only possible
/// through `Cell`, `RefCell`, global state, I/O, or unsafe code.
///
/// Both `push` and `pop` operations can be performed in `O(log(n))` time, whereas `peek` can be
Copy link
Contributor

@tesuji tesuji Apr 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should break at , to conform with surrounding documentation's style.

Copy link
Contributor Author

@DevQps DevQps Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man! Fixed it!

/// performed in `O(1)` time.
///
/// # Examples
///
/// ```
Expand Down