Skip to content

Update an outdated comment in mir building #56127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 3 commits into from
Nov 29, 2018
Merged

Update an outdated comment in mir building #56127

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83388e8
Update an outdated comment in mir building
oli-obk Nov 21, 2018
5a2a251
Update as_temp.rs
oli-obk Nov 21, 2018
925274a
Update as_temp.rs
oli-obk Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/librustc_mir/build/expr/as_temp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,8 @@ impl<'a, 'gcx, 'tcx> Builder<'a, 'gcx, 'tcx> {

unpack!(block = this.into(&Place::Local(temp), block, expr));

// In constants, temp_lifetime is None. We should not need to drop
// anything because no values with a destructor can be created in
// a constant at this time, even if the type may need dropping.
// In constants, temp_lifetime is None. We do not drop anything because
Copy link
Member

@eddyb eddyb Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not None except for the outermost scope. We need to keep all other drops in, to get errors about them (since they will execute in the future).

Copy link
Member

@eddyb eddyb Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nikomatsakis

// values with a destructor will simply be leaked in constants.
if let Some(temp_lifetime) = temp_lifetime {
this.schedule_drop_storage_and_value(
expr_span,
Expand Down