Canonicalize style of a few doc comments #52258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
steveklabnik
force-pushed
the
fix-doc-warnings
branch
from
7d4110c to
2d5d639
Compare
steveklabnik
changed the title
Contributor
|
#52164 already fixes this. |
Member
|
@euclio Yeah, looks that way. @steveklabnik, can you confirm, and either close or rebase as appropriate? |
Contributor
Author
|
That's fine too; let's take that one. Thanks/sorry all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, I noticed these because they used to warn; the warning was fixed, but the comments were in the unidiomatic style, so I re-did them and changed the flow slightly too.