NLL diagnostics: revise `fn check_access_permissions`#51275

Merged

bors merged 12 commits intorust-lang:masterfrom

pnkfelix:nll-diagnostics-revise-check-access-permissions

Jun 19, 2018

Commits on Jun 19, 2018

Thread info about form of variable bindings, including spans of arg types, down into `mir::LocalDecls`.
pnkfelix
committed
Refactor: Replace anonymous-tuple with tuple struct as prep for adding more fields in future.
pnkfelix
committed
Add `fn fn_decl` to `Hir`, for looking up the `FnDecl` of a body owner.
pnkfelix
committed
Thread more argument info down from `Hir` into the `mir::LocalDecls`.
pnkfelix
committed
small refactoring: replaced mutable state with `return` statements in control flow.
pnkfelix
committed
NLL: Broad rewrite of check_access_perimssions.
pnkfelix
committed
NLL: Updates to diagnostic output in `test/ui`.
pnkfelix
committed
updates to compile-fail tests for changes to NLL.
pnkfelix
committed
Added diagnostics for suggesting `mut x` on repeated mutations of `x`.
pnkfelix
committed
Update the existing UI tests to reflect diagnostic changes in NLL.
pnkfelix
committed
Update the existing compile-fail tests to reflect diagnostic changes in NLL.
pnkfelix
committed
Add unit test for case that didn't seem to be covered in existing UI tests
pnkfelix
committed