Skip to content

Fix doc tests for trim_right_matches #46128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Nov 21, 2017
Merged

Fix doc tests for trim_right_matches #46128

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3baa83
Fix doc tests for trim_right_matches
Arzte Nov 20, 2017
f69d4d4
Fix result for assert_eq
Arzte Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/liballoc/str.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1734,7 +1734,7 @@ impl str {
/// A more complex pattern, using a closure:
///
/// ```
/// assert_eq!("1fooX".trim_left_matches(|c| c == '1' || c == 'X'), "fooX");
/// assert_eq!("1fooX".trim_right_matches(|c| c == '1' || c == 'X'), "fooX");
Copy link
Member

@dtolnay dtolnay Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trimming from the right, the result would no longer be "fooX". I think it would be "1foo". https://play.rust-lang.org/?gist=433e02bea040f9f2364621f3cf0830a4

Copy link
Contributor Author

@Arzte Arzte Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I see it, nice response time tho.

/// ```
#[stable(feature = "rust1", since = "1.0.0")]
pub fn trim_right_matches<'a, P: Pattern<'a>>(&'a self, pat: P) -> &'a str
Expand Down