Skip to content

Add comment explaining the ctxt field in Span #45758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Nov 6, 2017
Merged

Add comment explaining the ctxt field in Span #45758

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2304b3a
Add comment explaining the ctxt field in Span
nzig Nov 4, 2017
0220600
Fix comment formatting
nzig Nov 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libsyntax_pos/span_encoding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,10 @@ const CTXT_INDEX: usize = 2;

// Tag = 0, inline format.
// -----------------------------------
// | base 31:8 | len 7:1 | tag 0:0 |
// | base 31:8 | len 7:1 | ctxt (currently 0 bits) | tag 0:0 |
// -----------------------------------
Copy link
Contributor

@petrochenkov petrochenkov Nov 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nzig
Could you add more ---s to make it a "closed box" again.

// Since there are zero bits for ctxt, only SpanData with a 0 SyntaxContext
// can be inline.
const INLINE_SIZES: [u32; 3] = [24, 7, 0];
const INLINE_OFFSETS: [u32; 3] = [8, 1, 1];

Expand Down