Skip to content

Conversation

@venkatagiri
Copy link
Contributor

@venkatagiri venkatagiri commented May 24, 2017

Arguments passed into this script from mingw and rustc seems to be different order.
I don't have enough understanding of the code to see if this is expected behavior.
Should i switch the arguments around?

r? @alexcrichton

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm
Copy link
Member

kennytm commented May 24, 2017

Hi, have you checked #41932?

@venkatagiri
Copy link
Contributor Author

@kennytm Oops. Forgot to check for existing PRs.
Should I go ahead and close this PR?

@aidanhs
Copy link
Contributor

aidanhs commented May 24, 2017

@venkatagiri yup it looks like these two are very similar so I'll go ahead and close this one since the other has already been reviewed. If you think there's something missing when the other gets merged, please do open a new PR (or just comment over there)!

@aidanhs aidanhs closed this May 24, 2017
@venkatagiri venkatagiri deleted the make_win_dist branch July 2, 2017 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants