-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[Doc] Improve thread::spawn documentation
#41854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -315,6 +315,8 @@ impl Builder { | |
| /// thread finishes). The join handle can be used to block on | ||
| /// termination of the child thread, including recovering its panics. | ||
| /// | ||
| /// For a more complete documentation see [`thread::spawn`][`spawn`]. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Unlike the [`spawn`] free function, this method yields an | ||
|
|
@@ -387,19 +389,19 @@ impl Builder { | |
| /// panics, [`join`] will return an [`Err`] containing the argument given to | ||
| /// [`panic`]. | ||
| /// | ||
| /// This will create a thread using default parameters of [`Builder`], if you | ||
| /// want to specify the stack size or the name of the thread, use this API | ||
| /// instead. | ||
| /// | ||
| /// # Panics | ||
| /// | ||
| /// Panics if the OS fails to create a thread; use [`Builder::spawn`] | ||
| /// to recover from such errors. | ||
| /// | ||
| /// [`JoinHandle`]: ../../std/thread/struct.JoinHandle.html | ||
| /// [`join`]: ../../std/thread/struct.JoinHandle.html#method.join | ||
| /// [`Err`]: ../../std/result/enum.Result.html#variant.Err | ||
| /// [`panic`]: ../../std/macro.panic.html | ||
| /// [`Builder::spawn`]: ../../std/thread/struct.Builder.html#method.spawn | ||
| /// | ||
| /// # Examples | ||
| /// | ||
| /// Simple thread creation. | ||
| /// | ||
| /// ``` | ||
| /// use std::thread; | ||
| /// | ||
|
|
@@ -409,6 +411,54 @@ impl Builder { | |
| /// | ||
| /// handler.join().unwrap(); | ||
| /// ``` | ||
| /// | ||
| /// As mentionned in the module documentation, threads are usualy made to | ||
|
||
| /// communicate using [`channel`s][`channels`], here is how it usually looks. | ||
|
||
| /// | ||
| /// This example also shows how to use `move`, in order to give ownership | ||
| /// of values to a thread. | ||
| /// | ||
| /// ``` | ||
| /// use std::thread; | ||
| /// use std::sync::mpsc::channel; | ||
| /// | ||
| /// let (tx, rx) = channel(); | ||
| /// | ||
| /// let sender = thread::spawn(move || { | ||
| /// tx.send("Hello, thread".to_owned()); | ||
| /// }); | ||
| /// | ||
| /// let receiver = thread::spawn(move || { | ||
| /// println!("{}", rx.recv().unwrap()); | ||
| /// }); | ||
| /// | ||
| /// sender.join(); | ||
| /// receiver.join(); | ||
| /// ``` | ||
| /// | ||
| /// A thread can also return a value through its [`JoinHandle`], you can use | ||
| /// this to make asynchronous computations (futures might be more appropriate | ||
| /// though). | ||
| /// | ||
| /// ``` | ||
| /// use std::thread; | ||
| /// | ||
| /// let computation = thread::spawn(|| { | ||
| /// // Some expensive computation. | ||
| /// 42 | ||
| /// }); | ||
| /// | ||
| /// let result = computation.join().unwrap(); | ||
| /// println!("{}", v); | ||
| /// ``` | ||
| /// | ||
| /// [`channels`]: ../../std/sync/mpsc/index.html | ||
| /// [`JoinHandle`]: ../../std/thread/struct.JoinHandle.html | ||
| /// [`join`]: ../../std/thread/struct.JoinHandle.html#method.join | ||
| /// [`Err`]: ../../std/result/enum.Result.html#variant.Err | ||
| /// [`panic`]: ../../std/macro.panic.html | ||
| /// [`Builder::spawn`]: ../../std/thread/struct.Builder.html#method.spawn | ||
| /// [`Builder`]: ../../std/thread/struct.Builder.html | ||
| #[stable(feature = "rust1", since = "1.0.0")] | ||
| pub fn spawn<F, T>(f: F) -> JoinHandle<T> where | ||
| F: FnOnce() -> T, F: Send + 'static, T: Send + 'static | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we say
instead here? I try to stick away from "simple" 😄