Skip to content

librustc: Make the Drop trait use explicit self #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pcwalton wants to merge 1 commit into from
Closed

librustc: Make the Drop trait use explicit self #4058

pcwalton wants to merge 1 commit into from

Conversation

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Nov 28, 2012

r? @brson

@brson
Copy link
Contributor

brson commented Nov 28, 2012

r+

@brson
Copy link
Contributor

brson commented Nov 29, 2012

I notice that the self type can't be mutated in the finalizer. I can't imagine that is a major limitation but it could cause some unforeseen pain.

Could this property of types being immutable in the finalizer be used to safely allow finalizers on managed boxes, without zombies?

@pcwalton pcwalton closed this Nov 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pcwalton @brson