Skip to content

Specialize PartialOrd<A> for [A] where A: Ord #39642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 3 commits into from Feb 11, 2017
Merged

Specialize PartialOrd<A> for [A] where A: Ord #39642

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bd6e46
Specialize `PartialOrd<A> for [A] where A: Ord`
Feb 8, 2017
ececbb2
Simplify by calling SliceOrd::compare
Feb 8, 2017
a344c12
Remove unnecessary specialization for [u8]
Feb 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/libcore/slice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2290,6 +2290,14 @@ impl<A> SlicePartialOrd<A> for [A]
}
}

impl<A> SlicePartialOrd<A> for [A]
where A: Ord
{
default fn partial_compare(&self, other: &[A]) -> Option<Ordering> {
Some(SliceOrd::compare(self, other))
}
}

impl SlicePartialOrd<u8> for [u8] {
Copy link
Contributor

@ollie27 ollie27 Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this impl not be extended to all A: Ord so it would simply use Some(SliceOrd::compare(self, other))?

Copy link
Author

@ghost ghost Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good suggestion, thanks! I've updated the code.

Copy link
Member

@alexcrichton alexcrichton Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this specialization could be removed now, right?

Copy link
Author

@ghost ghost Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, removed.

#[inline]
fn partial_compare(&self, other: &[u8]) -> Option<Ordering> {
Expand Down