-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
implementing RFC 1623. This fixes #35897. #35915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cfce351
first attempt at implementing RFC 1623. This fixes #35897.
llogiq 8bdb3e1
fix run-pass test
llogiq a6b9fea
fixed compile-fail test
llogiq e0eb1ba
fixed and extended tests, however...
llogiq 1fd85b1
fixed compile-fail test
llogiq 7443127
fixed and extended tests once more
llogiq e95f119
rustfmt tests
llogiq a87b4d8
removed unneeded test, also compiletest vs. rustfmt
llogiq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // Copyright 2012 The Rust Project Developers. See the COPYRIGHT | ||
| // file at the top-level directory of this distribution and at | ||
| // http://rust-lang.org/COPYRIGHT. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
| // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| #![allow(dead_code)] | ||
|
|
||
| fn non_elidable<'a, 'b>(a: &'a u8, b: &'b u8) -> &'a u8 { a } | ||
|
|
||
| // the boundaries of elision | ||
| static NON_ELIDABLE_FN : &fn(&u8, &u8) -> &u8 = | ||
| //~^ERROR: missing lifetime specifier | ||
| &(non_elidable as fn(&u8, &u8) -> &u8); | ||
|
|
||
| fn main() { | ||
| // nothing to do here | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| // Copyright 2012 The Rust Project Developers. See the COPYRIGHT | ||
| // file at the top-level directory of this distribution and at | ||
| // http://rust-lang.org/COPYRIGHT. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
| // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| #![allow(dead_code)] | ||
|
|
||
| // very simple test for a 'static static with default lifetime | ||
| static SOME_STATIC_STR : &str = "&'static str"; | ||
| const SOME_CONST_STR : &str = "&'static str"; | ||
|
|
||
| // this should be the same as without default: | ||
| static SOME_EXPLICIT_STATIC_STR : &'static str = "&'static str"; | ||
| const SOME_EXPLICIT_CONST_STR : &'static str = "&'static str"; | ||
|
|
||
| // a function that elides to an unbound lifetime for both in- and output | ||
| fn id_u8_slice(arg: &[u8]) -> &[u8] { arg } | ||
|
|
||
| // one with a function, argument elided | ||
| static SOME_STATIC_SIMPLE_FN : &fn(&[u8]) -> &[u8] = | ||
| &(id_u8_slice as fn(&[u8]) -> &[u8]); | ||
| const SOME_CONST_SIMPLE_FN : &fn(&[u8]) -> &[u8] = | ||
| &(id_u8_slice as fn(&[u8]) -> &[u8]); | ||
|
|
||
| // this should be the same as without elision | ||
| static SOME_STATIC_NON_ELIDED_fN : &for<'a> fn(&'a [u8]) -> &'a [u8] = | ||
| &(id_u8_slice as for<'a> fn(&'a [u8]) -> &'a [u8]); | ||
| const SOME_CONST_NON_ELIDED_fN : &for<'a> fn(&'a [u8]) -> &'a [u8] = | ||
| &(id_u8_slice as for<'a> fn(&'a [u8]) -> &'a [u8]); | ||
|
|
||
| // another function that elides, each to a different unbound lifetime | ||
| fn multi_args(a: &u8, b: &u8, c: &u8) { } | ||
|
|
||
| static SOME_STATIC_MULTI_FN : &fn(&u8, &u8, &u8) = | ||
| &(multi_args as fn(&u8, &u8, &u8)); | ||
| const SOME_CONST_MULTI_FN : &fn(&u8, &u8, &u8) = | ||
| &(multi_args as fn(&u8, &u8, &u8)); | ||
|
|
||
|
|
||
| fn main() { | ||
| // make sure that the lifetime is actually elided (and not defaulted) | ||
| let x = &[1u8, 2, 3]; | ||
| SOME_STATIC_SIMPLE_FN(x); | ||
| SOME_CONST_SIMPLE_FN(x); | ||
|
|
||
| // make sure this works with different lifetimes | ||
| let a = &1; | ||
| { | ||
| let b = &2; | ||
| let c = &3; | ||
| SOME_CONST_MULTI_FN(a, b, c); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget, did the RFC cover both constants and statics? Presumably yes.