Fix a few links in the book #34021
Merged
Fix a few links in the book #34021
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Links to directories and direct links to doc.rust-lang.org don't work properly when viewing the docs offline so fix them.
Contributor
|
Ah, nice catch. @bors: r+ rollup |
Collaborator
|
📌 Commit 658253d has been approved by |
Member
|
May be worth also updating the link checker script with this logic? On Wednesday, June 1, 2016, bors [email protected] wrote:
|
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 2, 2016
…klabnik Fix a few links in the book Links to directories and direct links to doc.rust-lang.org don't work properly when viewing the docs offline so fix them. r? @steveklabnik
bors
added a commit
that referenced
this pull request
Jun 2, 2016
Contributor
Author
|
yeah, I've modified linkchecker to treat directory links as errors in #34039. |
bors
added a commit
that referenced
this pull request
Jun 5, 2016
linkchecker: Treat directory links as errors Directory links don't work well offline so they should be treated as errors. All examples of this I know of are fixed in #34021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to directories and direct links to doc.rust-lang.org don't work properly
when viewing the docs offline so fix them.
r? @steveklabnik