Skip to content

Conversation

@alexcrichton
Copy link
Member

This commit renames the CString::{into_ptr, from_ptr} methods to into_raw
and from_raw to mirror the corresponding methods on Box and the naming of
"raw" for from_raw_parts on slices and vectors.

cc #27769

@rust-highfive
Copy link
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Collaborator

bors commented Aug 16, 2015

☔ The latest upstream changes (presumably #27818) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say from_raw here.

@bluss
Copy link
Contributor

bluss commented Aug 18, 2015

r=me with the docs updated

@bluss bluss assigned bluss and unassigned huonw Aug 18, 2015
This commit renames the `CString::{into_ptr, from_ptr}` methods to `into_raw`
and `from_raw` to mirror the corresponding methods on `Box` and the naming of
"raw" for `from_raw_parts` on slices and vectors.

cc rust-lang#27769
@alexcrichton
Copy link
Member Author

@bors: r=bluss 3cf9e10

bors added a commit that referenced this pull request Aug 18, 2015
This commit renames the `CString::{into_ptr, from_ptr}` methods to `into_raw`
and `from_raw` to mirror the corresponding methods on `Box` and the naming of
"raw" for `from_raw_parts` on slices and vectors.

cc #27769
@bors
Copy link
Collaborator

bors commented Aug 18, 2015

⌛ Testing commit 3cf9e10 with merge 2fb3fb2...

@bors bors merged commit 3cf9e10 into rust-lang:master Aug 18, 2015
@alexcrichton alexcrichton deleted the rename-cstring-raw branch August 21, 2015 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants