Skip to content

Add E0088, E0091, E0109 and E0110 and error explanation #26593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 6 commits into from
Jun 29, 2015
Merged

Add E0088, E0091, E0109 and E0110 and error explanation #26593

bors merged 6 commits into from
Jun 29, 2015

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jun 26, 2015

Part of #24407.
cc @michaelsproul

@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 26, 2015

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jun 26, 2015

r? @Manishearth

@GuillaumeGomez GuillaumeGomez changed the title Add E0091 error explanation Add E0091 and E0088 error explanation Jun 26, 2015
Manishearth
Manishearth reviewed Jun 26, 2015
View reviewed changes
src/librustc_typeck/diagnostics.rs Outdated
Copy link
Member

@Manishearth Manishearth Jun 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameters

@GuillaumeGomez GuillaumeGomez changed the title Add E0091 and E0088 error explanation Add E0088, E0091 and E0109 and error explanation Jun 27, 2015
Manishearth
Manishearth reviewed Jun 28, 2015
View reviewed changes
src/librustc/diagnostics.rs Outdated
Copy link
Member

@Manishearth Manishearth Jun 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please check that you used the correct type and recheck its definition. Perhaps it doesn't need the type parameter."

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jun 28, 2015

Updated.

Manishearth
Manishearth reviewed Jun 28, 2015
View reviewed changes
src/librustc/diagnostics.rs Outdated
Copy link
Member

@Manishearth Manishearth Jun 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a type parameter"

@GuillaumeGomez GuillaumeGomez changed the title Add E0088, E0091 and E0109 and error explanation Add E0088, E0091, E0109 and E0110 and error explanation Jun 29, 2015
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jun 29, 2015

Updated ! Do you see anything else @Manishearth ?

Manishearth
Manishearth reviewed Jun 29, 2015
View reviewed changes
src/librustc/diagnostics.rs Outdated
Copy link
Member

@Manishearth Manishearth Jun 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Jun 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "a" has been eaten by the void ! :O

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jun 29, 2015

Re-updated.

@Manishearth
Copy link
Member

Manishearth commented Jun 29, 2015

@bors r+ rollup

1 similar comment
@Manishearth
Copy link
Member

Manishearth commented Jun 29, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 29, 2015

📌 Commit 7f830a8 has been approved by Manishearth

@Manishearth Manishearth mentioned this pull request Jun 29, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 29, 2015
@Manishearth
Rollup merge of rust-lang#26593 - GuillaumeGomez:patch-2, r=Manishearth
4adcc78 
Part of rust-lang#24407.
cc @michaelsproul
bors added a commit that referenced this pull request Jun 29, 2015
@bors
Auto merge of #26649 - Manishearth:rollup, r=Manishearth
40db46c 
- Successful merges: #26593, #26644, #26645
- Failed merges:
@bors bors merged commit 7f830a8 into rust-lang:master Jun 29, 2015
@GuillaumeGomez GuillaumeGomez deleted the patch-2 branch June 29, 2015 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Manishearth Manishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez @rust-highfive @Manishearth @bors @michaelsproul @apasel422 @nikomatsakis