Skip to content

Conversation

@cactorium
Copy link
Contributor

For #24407

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@cactorium
Copy link
Contributor Author

@Manishearth r+ please?

@Manishearth
Copy link
Member

r? @michaelsproul

@Manishearth
Copy link
Member

@bors: r+

I don't see any other active diagnostics prs

@bors
Copy link
Collaborator

bors commented May 15, 2015

📌 Commit 507f8b8 has been approved by Manishearth

@Manishearth
Copy link
Member

@bors: rollup

@michaelsproul
Copy link
Contributor

I love it! 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put `'s around the second unsafe (since it's referring to the code entity specifically)?

Removing the `unsafe` keyword ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@huonw
Copy link
Contributor

huonw commented May 15, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 15, 2015

📌 Commit 190de69 has been approved by huonw

bors added a commit that referenced this pull request May 15, 2015
@bors
Copy link
Collaborator

bors commented May 15, 2015

⌛ Testing commit 190de69 with merge 072cba9...

@bors
Copy link
Collaborator

bors commented May 15, 2015

@bors bors merged commit 190de69 into rust-lang:master May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants