Skip to content

Add link to Debug trait #25376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
May 13, 2015
Merged

Add link to Debug trait #25376

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baef132
Add link to Debug trait
swaroopch May 13, 2015
f6e5369
trpl/error-handling - fix typo
swaroopch May 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/doc/trpl/error-handling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ match version {
This function makes use of an enum, `ParseError`, to enumerate the various
errors that can occur.

The [`Debug`](../core/fmt/trait.Debug.html) trait is what let's us print the enum value using the `{:?}` format operation.
Copy link
Member

@sfackler sfackler May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "lets", not "let's", right?

Copy link
Contributor

@steveklabnik steveklabnik May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, and it probably should be to std, not core.

@swaroopch , up for a second PR after this one lands? heh. It's already being tested in the rollup, or i'd say fix it first

Copy link
Contributor Author

@swaroopch swaroopch May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfackler @steveklabnik I added a second commit to same branch in my fork - f6e5369 - but I'm a bit confused on how this works - should I do a separate PR?

Copy link
Contributor

@steveklabnik steveklabnik May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! so, #25377 failed. so no, you don't need to make a new PR


# Non-recoverable errors with `panic!`

In the case of an error that is unexpected and not recoverable, the `panic!`
Expand Down