Skip to content

Conversation

@jxcl
Copy link
Contributor

@jxcl jxcl commented Feb 23, 2015

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{}s can be removed, this file still uses the old style, but i'd prefer to keep it the new style

@steveklabnik
Copy link
Contributor

r=me after some nits

@steveklabnik
Copy link
Contributor

@bos: r+ f49fd40 rollup

@steveklabnik
Copy link
Contributor

@bors: r+ f49fd40 rollup

@steveklabnik
Copy link
Contributor

Let's see if it works this time...

@steveklabnik
Copy link
Contributor

It has!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 26, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 27, 2015
@bors bors merged commit f49fd40 into rust-lang:master Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants