lint: fixup extraneous #[allow] #22374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This snuck through my refactor
Contributor
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
@bors r+ 7486 There has definitely been interest in "metadata only" builds, which would cover this sort of thing. |
Contributor
|
@bors rollup |
Contributor
Author
|
Is there a ticket/RFC for the metadata only builds? I'm still working through some power issues and have been offered access to ppc64le machines for a port, this would save me a lot of time. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 17, 2015
This snuck through my refactor. Would it be worth the effort to have a test pass that attempts to lint the code for all targets, even if it's not feasible to actually build and test it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This snuck through my refactor.
Would it be worth the effort to have a test pass that attempts to lint the code for all targets, even if it's not feasible to actually build and test it?