sized deallocation fixes#17012
Closed
thestinger wants to merge 5 commits intorust-lang:masterfrom
thestinger:sized
Closed
sized deallocation fixes#17012thestinger wants to merge 5 commits intorust-lang:masterfrom thestinger:sized
thestinger wants to merge 5 commits intorust-lang:masterfrom
thestinger:sized
Conversation
Contributor
|
r? @nick29581 |
bors
added a commit
that referenced
this pull request
Sep 6, 2014
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 24, 2023
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 25, 2023
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 26, 2023
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 27, 2023
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
May 26, 2024
Fix inconsistent cwd of `run` and `debug` command in client Fix rust-lang#17012. Also related to rust-lang#13022 and rust-lang#15993. When the `kind` of runnable is `bin`, Cargo would use the workspace root as the cwd for the `run` command; otherwise, Cargo defaults to the package root as the cwd for `run`. Initially, r-a assumed the workspace root as the cwd for all runnables in `debug` command, which led to issue rust-lang#13022. In this case, during unit testing, the `run` command would use the package root while `debug` would use the workspace root, causing inconsistency. PR rust-lang#15993 addressed this problem by using the package root as the cwd for `debug` command. However, it also resulted in an inconsistency: when executing the `run` command within the main fn of a package (whose target is `bin`), Cargo would use the workspace root, whereas `debug` would use the package root, leading to issue rust-lang#17012. The preferable approach is to determine the cwd based on the runnable's type. To resolve this, this PR introduces a new `cwd` field within `CargoRunnable`, allowing r-a to decide the appropriate cwd depending on the specific kind of the runnable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.