Move std::io::util to core::io#156431
Open
bushrat011899 wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Collaborator
|
r? @nia-e rustbot has assigned @nia-e. Use Why was this reviewer chosen?The reviewer was selected based on:
|
4 tasks
This comment has been minimized.
This comment has been minimized.
0b02f63 to
929f2a3
Compare
This comment has been minimized.
This comment has been minimized.
929f2a3 to
46f50fb
Compare
This comment has been minimized.
This comment has been minimized.
46f50fb to
72ca658
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Subset of: #154684
Description
Moves utility types and functions from
std::io::utilandstd::iotocore::io, leaving any IO trait implementations behind. They will be moved along with the traits themselves. Certain documentation links had to be amended.ChainEmptyRepeatSinkTakeemptyrepeatsinkNotes
alloc::ioandcore::io#154046.ChainandTakewere previously in the mainmod.rsfile forstd::io, but I've chosen to move them into theutil.rsfile incore::ioinstead. I think they make more sense in that file, but I'm happy to move them intomod.rsif that's a controversial decision.