Simplify intrinsic::raw_eq in MIR when possible#156429
Open
scottmcm wants to merge 2 commits intorust-lang:mainfrom
Open
Simplify intrinsic::raw_eq in MIR when possible#156429scottmcm wants to merge 2 commits intorust-lang:mainfrom
intrinsic::raw_eq in MIR when possible#156429scottmcm wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
Member
Author
|
r? mir-opt |
rustbot
added
the
S-waiting-on-review
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
oli-obk
reviewed
May 11, 2026
| struct InstSimplifyContext<'a, 'tcx> { | ||
| tcx: TyCtxt<'tcx>, | ||
| local_decls: &'a LocalDecls<'tcx>, | ||
| local_decls: &'a mut IndexVec<Local, LocalDecl<'tcx>>, |
Contributor
There was a problem hiding this comment.
Suggested change
| local_decls: &'a mut IndexVec<Local, LocalDecl<'tcx>>, | |
| local_decls: &'a mut LocalDecls<'tcx>, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #150945 things can inline enough to have this end up specific enough that we can remove it, for example changing
raw_eq::<[u8; 4]>(a, b)→Transmute(a) == Transmute(b).The LLVM backend can also do this (and in more cases too) but we might as well do it in MIR instead when we can so it applies to all backends and other MIR optimizations can apply afterwards.