Rollup of 6 pull requests#156424
Closed
GuillaumeGomez wants to merge 13 commits intorust-lang:mainfrom
Closed
Conversation
Previously ::floor() included an example showing behaviour for negative values, but ::ceil() did not. Ensure both have examples of the negative case, for both f32 and f64. Whilst we're here, tweak the wording slightly so it reads better.
…tmcm remove forever-deprecated and hidden `f64` methods The methods `f64::is_positive` and `f64::is_negative` were deprecated since 1.0 and marked as `#[doc(hidden)]` in favor of `f64::is_sign_positive` and `f64::is_sign_negative`. They also only exist on `f64`, not on `f32`. But for some unknown reason, they have been marked as stable. This PR proposes to remove both methods as they were never a part of the documented API, assuming that a crater run finds no significant breakage.
…crum Update ICU4X to 2.2 Needs a data regen.
…reads, r=Mark-Simulacrum kernel_copy tests: properly join background threads This helps Miri because when there are threads just hanging in the background, we cannot check for memory leaks. I think even without Miri this currently leads to 100% CPU load on one core for each of these threads: once the test function returns and `sink` gets dropped, the `read` in the thread will always immediately return `0`, and then we just loop with that forever until the process exits.
…y, r=clubby789 Refuse to push changes with a dirty git client I've run into the issue more than once where I've fixed an issue in my client but forgotten to commit it one way or another. The verification succeeds because the files on disk are correct even though the files in the commit being pushed are incorrect. This change checks to see if there are any uncommitted changes in tracked files in the client before running the tidy checks.
…ark-Simulacrum Update `sysinfo` version to `0.39.0` Bugfixes, new API and performance improvement. Full changelog is [here](https://github.com/GuillaumeGomez/sysinfo/blob/main/CHANGELOG.md).
…mulacrum Improve doc comments for f32::ceil() and f32::floor() Previously ::floor() included an example showing behaviour for negative values, but ::ceil() did not. Ensure both have examples of the negative case, for both f32 and f64. Whilst we're here, tweak the wording slightly so it reads better.
rustbot
added
A-tidy
Member
Author
|
@bors r+ p=5 rollup=never |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 11, 2026
Rollup of 6 pull requests Successful merges: - #153975 (remove forever-deprecated and hidden `f64` methods) - #156147 (Update ICU4X to 2.2) - #156375 (kernel_copy tests: properly join background threads) - #155946 (Refuse to push changes with a dirty git client) - #156282 (Update `sysinfo` version to `0.39.0`) - #156392 (Improve doc comments for f32::ceil() and f32::floor())
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 1a42c8b failed: CI. Failed job:
|
Contributor
|
This pull request was unapproved due to being closed. |
rust-bors
Bot
added
the
S-waiting-on-author
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
f64methods #153975 (remove forever-deprecated and hiddenf64methods)sysinfoversion to0.39.0#156282 (Updatesysinfoversion to0.39.0)r? @ghost
Create a similar rollup