Skip to content

Add missing translator resources for interface parse_cfg and parse_check_cfg #150659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jan 4, 2026
Merged

Add missing translator resources for interface parse_cfg and parse_check_cfg #150659

bors merged 1 commit into from
Jan 4, 2026
+37 −2

Conversation

@mu001999
Copy link
Contributor

@mu001999 mu001999 commented Jan 4, 2026 •
edited by rustbot
Loading

Missing resources leads to the failure of translate_message.

Fixes #150654

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2026

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Urgau
Urgau approved these changes Jan 4, 2026
View reviewed changes
Copy link
Member

@Urgau Urgau left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would use rustc_driver::DEFAULT_LOCALE_RESOURCES, which contains all the locale resources, but it's created to late for us here.

Looks good.

View changes since this review

@Urgau
Copy link
Member

Urgau commented Jan 4, 2026

r? Urgau @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 4, 2026

📌 Commit 759857c has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@Zalathar Zalathar mentioned this pull request Jan 4, 2026
Merged
bors added a commit that referenced this pull request Jan 4, 2026
@bors
Auto merge of #150669 - Zalathar:rollup-7ar4hqp, r=Zalathar
5afdf5d 
Rollup of 7 pull requests

Successful merges:

 - #150201 (compiletest: Support revisions in debuginfo (read: debugger) tests)
 - #150642 (mutex.rs: remove needless-maybe-unsized bounds)
 - #150643 (vec in-place-drop: avoid creating an intermediate slice)
 - #150650 (Forbid generic parameters in types of #[type_const] items)
 - #150658 (Clarify panic conditions in `Iterator::last`)
 - #150659 (Add missing translator resources for interface parse_cfg and parse_check_cfg)
 - #150666 (Fix ambig-unambig-ty-and-consts link)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit db41a15 into rust-lang:main Jan 4, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 4, 2026
rust-timer added a commit that referenced this pull request Jan 4, 2026
@rust-timer
Unrolled build for #150659
be7f2c2 
Rollup merge of #150659 - mu001999-contrib:fix/150654, r=Urgau

Add missing translator resources for interface parse_cfg and parse_check_cfg

Missing resources leads to the failure of `translate_message`.

Fixes #150654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

ICE while formatting fluent string (rustc --cfg foo="12xy")

5 participants

@mu001999 @rustbot @Urgau @bors @JonathanBrouwer