Add a regression test for issue 129865 #149421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
Member
|
Thanks! |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 29, 2025
Rollup of 5 pull requests Successful merges: - #147362 (Avoid suggesting constrain the associated type with unknown type) - #149395 (float::minimum/maximum: say which exact IEEE operation this corresponds to) - #149396 (Remove outdated comment) - #149421 (Add a regression test for issue 129865) - #149424 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
lcnr
reviewed
Dec 1, 2025
| //@ compile-flags: -Znext-solver | ||
| //@ check-pass | ||
| //@ edition:2021 | ||
|
|
Contributor
There was a problem hiding this comment.
would have been nice to add a "// Regression test for #129865. <one line explanation of what happened here" to test test.
That makes it a lot easier to figure out what it's supposed to be testing
Member
Author
There was a problem hiding this comment.
Okay, I'll add it when opening next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129865
Looks like the previous versions (
< 1.85.0) failed to normalize async block's upvar types containing constants but not anymore