Always force non-trimming of path in `unreachable_patterns` lint by estebank · Pull Request #135310 · rust-lang/rust

estebank · 2025-01-09T23:13:17Z

Creating a "trimmed DefID path" when no error is being emitted is an ICE (on purpose). If we create a trimmed path for a lint that is then silenced before being emitted causes a known ICE. This side-steps the issue by always using with_no_trimmed_path!.

This was verified to fix https://github.com/quinn-rs/quinn/, but couldn't write a repro case for the test suite.

Fix #135289.

Creating a "trimmed DefID path" when no error is being emitted is an ICE (on purpose). If we create a trimmed path for a lint that is then silenced before being emitted causes a known ICE. This side-steps the issue by always using `with_no_trimmed_path!`. This was verified to fix https://github.com/quinn-rs/quinn/, but couldn't write a repro case for the test suite. Fix rust-lang#135289.

rustbot · 2025-01-09T23:13:25Z

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-01-09T23:13:27Z

Some changes occurred in match checking

cc @Nadrieril

rust-log-analyzer · 2025-01-09T23:17:56Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

curl: (22) The requested URL returned error: 404
curl: (22) The requested URL returned error: 404
ERROR: failed to download llvm from ci

    HELP: There could be two reasons behind this:
        1) The host triple is not supported for `download-ci-llvm`.
        2) Old builds get deleted after a certain time.
    HELP: In either case, disable `download-ci-llvm` in your config.toml:
    [llvm]
    download-ci-llvm = false
    
Build completed unsuccessfully in 0:00:22

lqd · 2025-01-09T23:30:00Z

I had the same workaround locally, but still wondered where the lint was silenced for the unreachable arms in that crate 🤔.

estebank · 2025-01-09T23:41:59Z

@lqd my assumption it is because of cargo silencing the lint for deps, but it's only a guess.

lqd · 2025-01-10T00:03:24Z

Interesting possibility. They do that via --cap-lints=allow IIRC, so I would have expected this to allow unreachable patterns, that you check at the beginning of the typo const checking. But maybe they do so differently for this use-case via tests.

compiler-errors · 2025-01-10T01:41:15Z

Would be nice to have a test for this

Nadrieril · 2025-01-10T15:14:58Z

I don't get why a lint wasn't emitted, I too would really like a repro.

estebank · 2025-01-10T17:15:57Z

I identified it is happening at quinn-proto/src/tests/mod.rs:1640:9 and now I think it might be cross-crate macro shenanigans affecting the logic of lint emitting. I'll dig deeper.

Edit: If I don't find a more appropriate solution before then, we should beta-backport this change in 4/5 weeks.

compiler-errors · 2025-01-18T04:21:22Z

#135673 (comment)

@rustbot label: +beta-nominated

Nadrieril · 2025-01-19T21:28:23Z

well, merging because ICE and backports, would be nice to get a repro eventually but also shrug

@bors r+

bors · 2025-01-19T21:28:26Z

📌 Commit 93a1950 has been approved by Nadrieril

It is now in the queue for this repository.

Always force non-trimming of path in `unreachable_patterns` lint Creating a "trimmed DefID path" when no error is being emitted is an ICE (on purpose). If we create a trimmed path for a lint that is then silenced before being emitted causes a known ICE. This side-steps the issue by always using `with_no_trimmed_path!`. This was verified to fix https://github.com/quinn-rs/quinn/, but couldn't write a repro case for the test suite. Fix rust-lang#135289.

…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#135310 (Always force non-trimming of path in `unreachable_patterns` lint) - rust-lang#135446 (further improve panic_immediate_abort by removing rtprintpanic! messages) - rust-lang#135491 (Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents) - rust-lang#135542 (Add the concrete syntax for precise capturing to 1.82 release notes.) - rust-lang#135700 (Emit single privacy error for struct literal with multiple private fields and add test for `default_field_values` privacy) - rust-lang#135729 (Add debug assertions to compiler profile) - rust-lang#135736 (rustdoc: Fix flaky doctest test) - rust-lang#135738 (Replace usages of `map_or(bool, ...)` with `is_{some_and|none_or|ok_and}`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 5 pull requests Successful merges: - rust-lang#134276 (fully de-stabilize all custom inner attributes) - rust-lang#135237 (Match Ergonomics 2024: document and reorganize the currently-implemented feature gates) - rust-lang#135310 (Always force non-trimming of path in `unreachable_patterns` lint) - rust-lang#135446 (further improve panic_immediate_abort by removing rtprintpanic! messages) - rust-lang#135491 (Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#135310 - estebank:issue-135289, r=Nadrieril Always force non-trimming of path in `unreachable_patterns` lint Creating a "trimmed DefID path" when no error is being emitted is an ICE (on purpose). If we create a trimmed path for a lint that is then silenced before being emitted causes a known ICE. This side-steps the issue by always using `with_no_trimmed_path!`. This was verified to fix https://github.com/quinn-rs/quinn/, but couldn't write a repro case for the test suite. Fix rust-lang#135289.

estebank · 2025-01-20T18:50:37Z

@Nadrieril #135289 (comment)

Nadrieril · 2025-01-20T22:24:57Z

thx for your investigation @estebank btw!

lqd · 2025-01-20T22:36:48Z

A fixme would also be good, at least to track that the fix is suboptimal and more of a workaround for the ICE. But the test is a prerequisite for analysis to even know what the principled fix is in the first place. Maybe others can help.

Add fixme and test for issue rust-lang#135289 This PR: - adds a test minimizing issue rust-lang#135289 for PR rust-lang#135310 - adds a fixme about the suboptimal fix for the ICE I've verified the test indeed ICEs with 3f2f695 reverted. r? `@estebank`

Rollup merge of rust-lang#135833 - lqd:add-ice-test, r=compiler-errors Add fixme and test for issue rust-lang#135289 This PR: - adds a test minimizing issue rust-lang#135289 for PR rust-lang#135310 - adds a fixme about the suboptimal fix for the ICE I've verified the test indeed ICEs with 3f2f695 reverted. r? `@estebank`

apiraino · 2025-01-23T15:11:29Z

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

[beta] backports - Always force non-trimming of path in `unreachable_patterns` lint rust-lang#135310 - Add Profile Override for Non-Git Sources rust-lang#135433 - resolve symlinks of LLVM tool binaries before copying them rust-lang#135585 - add cache to `AmbiguityCausesVisitor` rust-lang#135618 - When LLVM's location discriminator value limit is exceeded, emit locations with dummy spans instead of dropping them entirely rust-lang#135643 - Temporarily bring back `Rvalue::Len` rust-lang#135709 - make it possible to use ci-rustc on tarball sources rust-lang#135722 - Remove test panic from File::open rust-lang#135837 - Only assert the `Parser` size on specific arches rust-lang#135855 r? cuviper

[beta] backports - Always force non-trimming of path in `unreachable_patterns` lint rust-lang#135310 - Add Profile Override for Non-Git Sources rust-lang#135433 - resolve symlinks of LLVM tool binaries before copying them rust-lang#135585 - add cache to `AmbiguityCausesVisitor` rust-lang#135618 - When LLVM's location discriminator value limit is exceeded, emit locations with dummy spans instead of dropping them entirely rust-lang#135643 - Temporarily bring back `Rvalue::Len` rust-lang#135709 - make it possible to use ci-rustc on tarball sources rust-lang#135722 - Remove test panic from File::open rust-lang#135837 - Only assert the `Parser` size on specific arches rust-lang#135855 - [beta] TRPL: more backward-compatible Edition changes rust-lang#135843 r? cuviper

[beta] backports - Always force non-trimming of path in `unreachable_patterns` lint rust-lang#135310 - Add Profile Override for Non-Git Sources rust-lang#135433 - resolve symlinks of LLVM tool binaries before copying them rust-lang#135585 - add cache to `AmbiguityCausesVisitor` rust-lang#135618 - When LLVM's location discriminator value limit is exceeded, emit locations with dummy spans instead of dropping them entirely rust-lang#135643 - make it possible to use ci-rustc on tarball sources rust-lang#135722 - Remove test panic from File::open rust-lang#135837 - Only assert the `Parser` size on specific arches rust-lang#135855 - [beta] TRPL: more backward-compatible Edition changes rust-lang#135843 r? cuviper

rustbot assigned Nadrieril Jan 9, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 9, 2025

estebank mentioned this pull request Jan 9, 2025

ICE: trimmed_def_paths called, diagnostics were expected but none were emitted #135289

Closed

compiler-errors mentioned this pull request Jan 18, 2025

regression: ICE: trimmed_def_paths called, diagnostics were expected but none were emitted #135673

Closed

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2025

GuillaumeGomez mentioned this pull request Jan 19, 2025

Rollup of 8 pull requests #135746

Closed

jieyouxu mentioned this pull request Jan 20, 2025

Rollup of 5 pull requests #135755

Merged

bors merged commit 3f2f695 into rust-lang:master Jan 20, 2025
6 checks passed

rustbot added this to the 1.86.0 milestone Jan 20, 2025

lqd mentioned this pull request Jan 21, 2025

Add fixme and test for issue #135289 #135833

Merged

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 23, 2025

cuviper mentioned this pull request Jan 24, 2025

[beta] backports #136017

Merged

cuviper modified the milestones: 1.86.0, 1.85.0 Jan 24, 2025

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 24, 2025

Uh oh!

Conversation

estebank commented Jan 9, 2025

Uh oh!

rustbot commented Jan 9, 2025

Uh oh!

rustbot commented Jan 9, 2025

Uh oh!

rust-log-analyzer commented Jan 9, 2025

Uh oh!

lqd commented Jan 9, 2025

Uh oh!

estebank commented Jan 9, 2025

Uh oh!

lqd commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Jan 10, 2025

Uh oh!

Nadrieril commented Jan 10, 2025

Uh oh!

estebank commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Jan 18, 2025

Uh oh!

Nadrieril commented Jan 19, 2025

Uh oh!

bors commented Jan 19, 2025

Uh oh!

Uh oh!

estebank commented Jan 20, 2025

Uh oh!

Nadrieril commented Jan 20, 2025

Uh oh!

lqd commented Jan 20, 2025

Uh oh!

apiraino commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Comments

lqd commented Jan 10, 2025 •

edited

Loading

estebank commented Jan 10, 2025 •

edited

Loading