Skip to content

Conversation

@kpreid
Copy link
Contributor

@kpreid kpreid commented Dec 21, 2024

Since #133226, it is no longer automatically implemented, but must be manually implemented, with special restrictions. The documentation now (roughly) explains those special restrictions.

cc @compiler-errors (author of the previous PR)

@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 21, 2024
@kpreid
Copy link
Contributor Author

kpreid commented Dec 21, 2024

Whoops, looks like someone got to this already today, in 159dba8.
I still have something to add, though. Resolved the conflict.

@kpreid kpreid changed the title Correct documentation for PointerLike about automatic implementation. Document PointerLike implementation restrictions. Dec 21, 2024
@tgross35
Copy link
Contributor

This seems consistent with current use and with intent.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 22, 2024

📌 Commit da6616c has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2024
@bors bors merged commit 7f36ae4 into rust-lang:master Dec 22, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 22, 2024
@kpreid kpreid deleted the pointerlike-doc branch December 22, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants