Fix rustdoc missing handling of remap-path-prefix option#128736
Fix rustdoc missing handling of remap-path-prefix option#128736bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-remap-path-prefix
branch
from
27e193c to
f43e92b
Compare
|
Fixed fmt... |
|
One question: Should rustdoc respect From my understanding, besides doctest, the only thing needing to be remapped in rustdoc is diagnostics. Rustdoc might not need to be aware of any scope. Cargo can determine and pass |
|
My answer will be: if you can find a case where it's useful, I can add it. :) |
Is there anything that contains absolute/original source path in rustdoc generated artifacts? |
|
Not that I can think of. |
|
This definitely seems like an improvement. @bors r+
Source code pages can. Here's an example of how to see that. |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#128369 (rustc_lint: make `let-underscore-lock` translatable) - rust-lang#128377 (Fix ICE Caused by Incorrectly Delaying E0107) - rust-lang#128517 (Fallback to string formatting if source is not available for lint) - rust-lang#128685 (Remove the root Cargo.lock from the rust-src component) - rust-lang#128693 (rustdoc-search: account for numeric disambiguators on impls) - rust-lang#128720 (Pass the right `ParamEnv` to `might_permit_raw_init_strict`) - rust-lang#128736 (Fix rustdoc missing handling of remap-path-prefix option) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128736 - GuillaumeGomez:fix-remap-path-prefix, r=notriddle Fix rustdoc missing handling of remap-path-prefix option Fixes rust-lang#69264. cc `@weihanglo` r? `@notriddle`
6 participants
Fixes #69264.
cc @weihanglo
r? @notriddle