linker: Refactor interface for passing arguments to linker by petrochenkov · Pull Request #126832 · rust-lang/rust

petrochenkov · 2024-06-22T14:12:26Z

Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both.
Also avoid allocations in all the argument passing functions.

The interfaces would look nicer if not the limitations on returning &mut Self in dyn-compatible traits, and unnecessary conflicts between Trait and dyn Trait methods.

try-job: armhf-gnu
try-job: aarch64-gnu
try-job: dist-x86_64-linux
try-job: x86_64-msvc
try-job: i686-msvc
try-job: dist-x86_64-apple
try-job: test-various

rustbot · 2024-06-22T14:12:33Z

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

BoxyUwU · 2024-06-27T09:36:13Z

r? compiler

jieyouxu

Thanks, the changes look good, I'll throw it at a bunch of random try jobs in case some test somewhere catches any unintended changes. If the try jobs come back green, then r=me!

jieyouxu · 2024-06-29T07:52:46Z

@bors try

bors · 2024-06-29T07:53:57Z

⌛ Trying commit a981507 with merge 7439056...

linker: Refactor interface for passing arguments to linker Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both. Also avoid allocations in all the argument passing functions. The interfaces would look nicer if not the limitations on returning `&mut Self` in `dyn`-compatible traits, and unnecessary conflicts between `Trait` and `dyn Trait` methods. try-job: armhf-gnu try-job: aarch64-gnu try-job: dist-x86_64-linux try-job: x86_64-msvc try-job: i686-msvc try-job: dist-x86_64-apple try-job: test-various

bors · 2024-06-29T08:30:38Z

💔 Test failed - checks-actions

compiler/rustc_codegen_ssa/src/back/linker.rs

petrochenkov · 2024-07-01T10:10:04Z

From looking at the code it's not clear how this may happen for --target=wasm32-wasip1, let's try again with some additional debugging.
@bors try

linker: Refactor interface for passing arguments to linker Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both. Also avoid allocations in all the argument passing functions. The interfaces would look nicer if not the limitations on returning `&mut Self` in `dyn`-compatible traits, and unnecessary conflicts between `Trait` and `dyn Trait` methods. try-job: test-various

bors · 2024-07-01T10:11:15Z

⌛ Trying commit 16eada4 with merge e6882ad...

bors · 2024-07-01T10:48:33Z

💔 Test failed - checks-actions

…path

petrochenkov · 2024-07-01T11:33:28Z

@bors try

bors · 2024-07-01T11:34:38Z

⌛ Trying commit 5f9a0d3 with merge 89280e1...

linker: Refactor interface for passing arguments to linker Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both. Also avoid allocations in all the argument passing functions. The interfaces would look nicer if not the limitations on returning `&mut Self` in `dyn`-compatible traits, and unnecessary conflicts between `Trait` and `dyn Trait` methods. try-job: armhf-gnu try-job: aarch64-gnu try-job: dist-x86_64-linux try-job: x86_64-msvc try-job: i686-msvc try-job: dist-x86_64-apple try-job: test-various

bors · 2024-07-01T14:19:20Z

☀️ Try build successful - checks-actions
Build commit: 89280e1 (89280e16f1e6b7aaeebe74303dc6db3c4cdc7b20)

petrochenkov · 2024-07-01T14:26:09Z

@bors r=jieyouxu

bors · 2024-07-01T14:26:12Z

📌 Commit 5f9a0d3 has been approved by jieyouxu

It is now in the queue for this repository.

…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#126732 (Stabilize `PanicInfo::message()` and `PanicMessage`) - rust-lang#126753 (Add nightly style guide section for `precise_capturing` `use<>` syntax) - rust-lang#126832 (linker: Refactor interface for passing arguments to linker) - rust-lang#126880 (Migrate `volatile-intrinsics`, `weird-output-filenames`, `wasm-override-linker`, `wasm-exceptions-nostd` to `rmake`) - rust-lang#127128 (Stabilize `duration_abs_diff`) - rust-lang#127129 (Use full expr span for return suggestion on type error/ambiguity) - rust-lang#127188 ( improve the way bootstrap handles rustlib components) - rust-lang#127201 (Improve run-make-support API) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#126832 - petrochenkov:linkarg, r=jieyouxu linker: Refactor interface for passing arguments to linker Separate arguments into passed to the underlying linker, to cc wrapper, or supported by both. Also avoid allocations in all the argument passing functions. The interfaces would look nicer if not the limitations on returning `&mut Self` in `dyn`-compatible traits, and unnecessary conflicts between `Trait` and `dyn Trait` methods. try-job: armhf-gnu try-job: aarch64-gnu try-job: dist-x86_64-linux try-job: x86_64-msvc try-job: i686-msvc try-job: dist-x86_64-apple try-job: test-various

rustbot assigned BoxyUwU Jun 22, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2024

rustbot assigned jieyouxu and unassigned BoxyUwU Jun 27, 2024

jieyouxu approved these changes Jun 29, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2024

jieyouxu reviewed Jun 29, 2024

View reviewed changes

compiler/rustc_codegen_ssa/src/back/linker.rs Show resolved Hide resolved

petrochenkov force-pushed the linkarg branch from a981507 to 16eada4 Compare July 1, 2024 10:08

This comment has been minimized.

Sign in to view

petrochenkov added 2 commits July 1, 2024 14:19

linker: Refactor interface for passing arguments to linker

af31c33

linker: Bail out of rpath logic early if the target doesn't support r…

5f9a0d3

…path

petrochenkov force-pushed the linkarg branch from 16eada4 to 5f9a0d3 Compare July 1, 2024 11:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2024

GuillaumeGomez mentioned this pull request Jul 1, 2024

Rollup of 8 pull requests #127216

Merged

bors merged commit 6b2e644 into rust-lang:master Jul 1, 2024

rustbot added this to the 1.81.0 milestone Jul 1, 2024

petrochenkov deleted the linkarg branch February 22, 2025 18:28

Uh oh!

Conversation

petrochenkov commented Jun 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 22, 2024

Uh oh!

BoxyUwU commented Jun 27, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jun 29, 2024

Uh oh!

bors commented Jun 29, 2024

Uh oh!

This comment has been minimized.

bors commented Jun 29, 2024

Uh oh!

Uh oh!

petrochenkov commented Jul 1, 2024

Uh oh!

bors commented Jul 1, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 1, 2024

Uh oh!

petrochenkov commented Jul 1, 2024

Uh oh!

bors commented Jul 1, 2024

Uh oh!

bors commented Jul 1, 2024

Uh oh!

petrochenkov commented Jul 1, 2024

Uh oh!

bors commented Jul 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

petrochenkov commented Jun 22, 2024 •

edited

Loading