Ignore branch-protection-check-IBT run-make test

[Rejyr]

The old Makefile implementation (#110304) had an improper comparison which caused the test to never run. However, both the updated Makefile implementation and the rmake implementation fail (missing .note.gnu.property). This could be a bug in the original implementation or test flakiness.

Edit: Manually recreating the test case shows that .note.gnu.property does not appear in nightly.

// main.rs
fn main() {
    println!("hello world");
}

$ rustc +nightly -V
rustc 1.81.0-nightly (c1b336cb6 2024-06-21)
$ rustc +stable -V
rustc 1.79.0 (129f3b996 2024-06-10)

$ rustc +nightly -Zcf-protection=branch -Clink-args=-nostartfiles -Csave-temps "-L$PWD" main.rs -o main
$ llvm-readobj --elf-output-style=GNU -nW main
Displaying notes found in: .note.gnu.build-id
  Owner                Data size        Description
  GNU                  0x00000008       NT_GNU_BUILD_ID (unique build ID bitstring)
    Build ID: bcae34e6431b2a37

Compiling without the other flags still does not show .note.gnu.property.

$ rustc +nightly main.rs -o main
$ llvm-readobj --elf-output-style=GNU -nW main
Displaying notes found in: .note.ABI-tag
  Owner                Data size        Description
  GNU                  0x00000010       NT_GNU_ABI_TAG (ABI version tag)
    OS: Linux, ABI: 4.4.0

Displaying notes found in: .note.gnu.build-id
  Owner                Data size        Description
  GNU                  0x00000008       NT_GNU_BUILD_ID (unique build ID bitstring)
    Build ID: d60d5f108b63bf3a

Compiling on stable shows .note.gnu.property.

$ rustc +stable main.rs -o main
$ llvm-readobj --elf-output-style=GNU -nW main
Displaying notes found in: .note.gnu.property
  Owner                Data size        Description
  GNU                  0x00000010       NT_GNU_PROPERTY_TYPE_0 (property note)
    Properties:    x86 ISA needed: x86-64-baseline


Displaying notes found in: .note.gnu.build-id
  Owner                Data size        Description
  GNU                  0x00000014       NT_GNU_BUILD_ID (unique build ID bitstring)
    Build ID: 4a494eb578123314e6ff1caf1c8877e27004664f

Displaying notes found in: .note.ABI-tag
  Owner                Data size        Description
  GNU                  0x00000010       NT_GNU_ABI_TAG (ABI version tag)
    OS: Linux, ABI: 4.4.0

Part of #121876.

r? @jieyouxu

[Rejyr]

This compares x86 to x86_64, which always evaluates to false.

[Rejyr]

@jieyouxu This seems to be an error in the implementation. Should this be marked with a FIXME with the test case ignored?

[jieyouxu]

@Rejyr yes, can you drop the support library changes but keep both the Makefile and rmake.rs changes, and add an # ignore-test or //@ ignore-test directive on both (with a FIXME explaining the problem)? I'll take a closer look separately next week (i.e. let's merge this PR to ignore the not-doing-anything test first, then we can try to fix it).
@rustbot author

[jieyouxu]

Thanks, I can r+ this once you are ready to take it out of draft.

[rustbot]

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

[jieyouxu]

Thanks!
@bors r+ rollup

[bors]

📌 Commit 75a9379 has been approved by jieyouxu

It is now in the queue for this repository.